-
-
Notifications
You must be signed in to change notification settings - Fork 27
Feat: rr support with db backend experiment #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alehander92
wants to merge
31
commits into
main
Choose a base branch
from
feat-rr-with-db-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ac126f to
2d5f276
Compare
c549472 to
67a6ec0
Compare
869c578 to
e758084
Compare
dcc446c to
e2bed0a
Compare
there were problems with stdio, this is just ok for now some help from Nikola for some bugs
i(alexander) wasn't sure if it can work well bidirectionally, but it seems it's ok
…d_location for rr
loading locals still TODO in rr; overally not very tested in db
…ete generated test tcp test by mistake committed before: generated with gemini/zed iirc: removing, maybe if we add full tcp support we can add it problem: dap backend server still seems to have an error, at least stdio one works
TODO: a lot of things; is it ok to test like this a closed source part: ct-rr-worker? also, depends on many build artifacts that are not stable/ready for others (lldbinit.py in workdir: src/db-backend; ct-rr-worker build) also, a problem with socket in the end, non-critical also depends on local `rr-trace` in src/db-backend: it can be recorded from rust `rr_gdb.rs` from `codetracer-rr-backend`: TODO automate this for test? currently ignored by default: run with `cargo test -- --ignored rr`
* testing: * add a simple test for it in rr_test * add a timeout for the rr test for now with the `ntest` crate * impl: * start refactoring flow_preloader; not finished
… for location for now working in simple cases for db-backend, and at least not crashing for some for rr; but not yet a good example of working for rr; a small fix that tries to repeat the function first/last info for each of the lines in range in expr_loader; maybe we can instead check the region but for now hopefully an ok fix IMPORTANT: some problems overally: jumps and some flow in db-backend seem to be broken
not sure why we seem to still receive additional stopped after maybe complete-move/response, but it doesn't seem to be a problem
i forgot that now we mostly move with `self.replay`, so just changing the handler step_id might not be enough problem with iterate_asteroids flow remains
also TODO: add rr logic for the new primitives
moved setBreakpoints logic to handler; implemented some of the methods and placeholders for the others
…re jump_to_call TODO: rr jump_to_call
…he newer value form useful for rr: for now add some convert functions for compatibility; maybe in the future try to replace the old `Value` with the newer versions
try with upstream `rr` in PATH and ct rr worker trying to use it: but hanging; the test seems to be ok with the dev worker
building but not tested correctly: also more work! TODO
e2bed0a to
f95979e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the feature depends on connecting with IPC/socket to a worker, built from some of our closed source code: currently only db-backend is open source, not rr-backend or the new rr worker code
(many things are currently custom there/configured only on my machine, so the build needs to be fixed if we merge something like this)
(more info in our private rr backend repo PR 17 )